fix: require explicit share permission for bulk submission endpoints#3290
Merged
Chartman123 merged 2 commits intomainfrom Apr 14, 2026
Merged
fix: require explicit share permission for bulk submission endpoints#3290Chartman123 merged 2 commits intomainfrom
Chartman123 merged 2 commits intomainfrom
Conversation
Add permission guard to deleteAllSubmissions() to verify the user holds the required share-level permission, matching the pattern already used by the single-item endpoint. -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Chartman123
approved these changes
Apr 14, 2026
Collaborator
|
/backport to stable5.2 |
|
The backport to # Switch to the target branch and update it
git checkout stable5.2
git pull origin stable5.2
# Create the new backport branch
git checkout -b backport/3290/stable5.2
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ae7e5b54 60391131
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3290/stable5.2Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
pringelmann
added a commit
that referenced
this pull request
Apr 14, 2026
…3290) * fix: require explicit share permission for bulk submission actions Add permission guard to deleteAllSubmissions() to verify the user holds the required share-level permission, matching the pattern already used by the single-item endpoint. -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> * PR feedback -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> --------- Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Chartman123
pushed a commit
that referenced
this pull request
Apr 14, 2026
…n endpoints (#3292) fix: require explicit share permission for bulk submission endpoints (#3290) * fix: require explicit share permission for bulk submission actions Add permission guard to deleteAllSubmissions() to verify the user holds the required share-level permission, matching the pattern already used by the single-item endpoint. -e * PR feedback -e --------- Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk submission endpoints (
deleteAllSubmissions, etc.) previously relied on the form-levelallowEditSubmissionsflag to gate access, which meant a user with only submit permission could reach them if that flag was enabled. Align them with the single-item endpoint and require the explicit share-level permission instead.